Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1860663002: [devil] Set cache token only after successful initialization. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 7 months ago
Reviewers:
agrieve
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove errant run_tests_helper change #

Patch Set 3 : +tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M devil/devil/android/device_utils.py View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M devil/devil/android/device_utils_test.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jbudorick
4 years, 8 months ago (2016-04-04 19:58:09 UTC) #2
agrieve
On 2016/04/04 19:58:09, jbudorick wrote: lgtm
4 years, 8 months ago (2016-04-04 20:00:15 UTC) #3
jbudorick
https://codereview.chromium.org/1860663002/diff/1/devil/devil/utils/run_tests_helper.py File devil/devil/utils/run_tests_helper.py (right): https://codereview.chromium.org/1860663002/diff/1/devil/devil/utils/run_tests_helper.py#newcode33 devil/devil/utils/run_tests_helper.py:33: def SetLogLevel(verbose_count, formatter=None): er, this snuck in from another ...
4 years, 8 months ago (2016-04-04 20:01:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860663002/20001
4 years, 8 months ago (2016-04-04 20:06:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860663002/40001
4 years, 8 months ago (2016-04-04 21:11:30 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 21:24:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698