Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: devil/devil/android/device_utils_test.py

Issue 1860663002: [devil] Set cache token only after successful initialization. (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: +tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « devil/devil/android/device_utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: devil/devil/android/device_utils_test.py
diff --git a/devil/devil/android/device_utils_test.py b/devil/devil/android/device_utils_test.py
index 7ef5a3122114e907847548081ee41eb79da53d1e..fc6d185f2ad79cd2cdde618f03ac0d5c92d44c9e 100755
--- a/devil/devil/android/device_utils_test.py
+++ b/devil/devil/android/device_utils_test.py
@@ -1888,6 +1888,34 @@ class DeviceUtilsSetJavaAssertsTest(DeviceUtilsTest):
self.assertFalse(self.device.SetJavaAsserts(True))
+class DeviceUtilsEnsureCacheInitializedTest(DeviceUtilsTest):
+
+ def testEnsureCacheInitialized_noCache_success(self):
+ self.assertIsNone(self.device._cache['token'])
+ with self.assertCall(
+ self.call.device.RunShellCommand(
+ AnyStringWith('getprop'), check_return=True, large_output=True),
+ ['/sdcard', 'TOKEN']):
+ self.device._EnsureCacheInitialized()
+ self.assertIsNotNone(self.device._cache['token'])
+
+ def testEnsureCacheInitialized_noCache_failure(self):
+ self.assertIsNone(self.device._cache['token'])
+ with self.assertCall(
+ self.call.device.RunShellCommand(
+ AnyStringWith('getprop'), check_return=True, large_output=True),
+ self.TimeoutError()):
+ with self.assertRaises(device_errors.CommandTimeoutError):
+ self.device._EnsureCacheInitialized()
+ self.assertIsNone(self.device._cache['token'])
+
+ def testEnsureCacheInitialized_cache(self):
+ self.device._cache['token'] = 'TOKEN'
+ with self.assertCalls():
+ self.device._EnsureCacheInitialized()
+ self.assertIsNotNone(self.device._cache['token'])
+
+
class DeviceUtilsGetPropTest(DeviceUtilsTest):
def testGetProp_exists(self):
« no previous file with comments | « devil/devil/android/device_utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698