Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1860443003: Revert of [heap] Add optimized RecordWrites (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
ulan, Hannes Payer (out of office), v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Add optimized RecordWrites (patchset #3 id:40001 of https://codereview.chromium.org/1834373003/ ) Reason for revert: [Sheriff] Likely causing blink crashes: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/3667 Original issue's description: > [heap] Add optimized RecordWrites > BUG= > > Committed: https://crrev.com/5210f167e802a3758aac1f2900a6560c8de07831 > Cr-Commit-Position: refs/heads/master@{#35231} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org,cbruni@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/3fabe1a452412f6a4cd6ad9c16b2bd49126d8ff9 Cr-Commit-Position: refs/heads/master@{#35235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -27 lines) Patch
M src/elements.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +7 lines, -1 line 0 comments Download
M src/heap/heap-inl.h View 1 chunk +3 lines, -14 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
Created Revert of [heap] Add optimized RecordWrites
4 years, 8 months ago (2016-04-04 12:16:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860443003/1
4 years, 8 months ago (2016-04-04 12:16:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 12:16:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3fabe1a452412f6a4cd6ad9c16b2bd49126d8ff9 Cr-Commit-Position: refs/heads/master@{#35235}
4 years, 8 months ago (2016-04-04 12:18:02 UTC) #6
Michael Achenbach
4 years, 8 months ago (2016-04-04 12:24:09 UTC) #7
Message was sent while issue was closed.
FYI hablich: The crashing blink dbg builder is not part of the lkgr. So it's
possible we might get a roll including this commit 5210f167e802.

Powered by Google App Engine
This is Rietveld 408576698