Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: src/heap/heap-inl.h

Issue 1860443003: Revert of [heap] Add optimized RecordWrites (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap-inl.h
diff --git a/src/heap/heap-inl.h b/src/heap/heap-inl.h
index df9072e78020dc07f3658f4a50ff1febb4b7d049..7b2f5ead9b9a3ff53617f12212ebdfe253f99eac 100644
--- a/src/heap/heap-inl.h
+++ b/src/heap/heap-inl.h
@@ -399,20 +399,9 @@
if (!InNewSpace(o) || !object->IsHeapObject() || InNewSpace(object)) {
return;
}
- RememberedSet<OLD_TO_NEW>::Insert(
- Page::FromAddress(reinterpret_cast<Address>(object)),
- HeapObject::cast(object)->address() + offset);
-}
-
-void Heap::RecordFixedArrayElements(FixedArray* array, int offset, int length) {
- if (InNewSpace(array)) return;
- Page* page = Page::FromAddress(reinterpret_cast<Address>(array));
- for (int i = 0; i < length; i++) {
- if (!InNewSpace(array->get(i))) continue;
- RememberedSet<OLD_TO_NEW>::Insert(
- page,
- reinterpret_cast<Address>(array->RawFieldOfElementAt(offset + i)));
- }
+ Page* page = Page::FromAddress(reinterpret_cast<Address>(object));
+ Address slot = HeapObject::cast(object)->address() + offset;
+ RememberedSet<OLD_TO_NEW>::Insert(page, slot);
}
« no previous file with comments | « src/heap/heap.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698