Bookmark sync promo for Views.

chrome/browser/ui/sync/sync_promo_ui.cc

Index: chrome/browser/ui/sync/sync_promo_ui.cc
diff --git a/chrome/browser/ui/sync/sync_promo_ui.cc b/chrome/browser/ui/sync/sync_promo_ui.cc
index 8698f14e5c33fe7eb6f89af68d40d70001c5b06a..078377da0ce42665bb1fa10e71e2b5e355a2fcf2 100644
--- a/chrome/browser/ui/sync/sync_promo_ui.cc
+++ b/chrome/browser/ui/sync/sync_promo_ui.cc
@@ -97,10 +97,6 @@ bool SyncPromoUI::ShouldShowSyncPromo(Profile* profile) {
   if (net::NetworkChangeNotifier::IsOffline())
     return false;
 
-  // Don't show if the profile is an incognito.
-  if (profile->IsOffTheRecord())
-    return false;
-

[Roger Tawa OOO till Jul 10th, 2013/07/11 15:28:30]

Why do we need this check?  We don't suppress other sign in access points in
incognito.  Also, it seems from section "Behavior of the “Sign in” link", 2a, in
the design doc that incognito would be supported.

If we do want to suppress in incognito, maybe add a test for this case?

[fdoray, 2013/07/11 19:00:40]

SyncPromoUI::ShouldShowSyncPromo is used to determine if the bookmark sync promo
should be displayed. Removing this makes the sync promo visible in incognito, as
we want.

To my knowledge, SyncPromoUI::ShouldShowSyncPromo is never used in incognito
currently, so this change has no impact on existing code.
- If you install an extension from incognito, ExtensionInstalledBubble is
displayed in a normal browser.
- The incognito NTP doesn't even call SyncPromoUI::ShouldShowSyncPromo.

On 2013/07/11 15:28:30, Roger Tawa wrote:

   // Don't show for managed profiles.
   if (profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged))
     return false;