Bookmark sync promo for Views.

chrome/browser/ui/sync/sync_promo_ui.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/sync_promo_ui.h"
 
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 79 matching lines @@
 #if defined(OS_CHROMEOS)
   // There's no need to show the sync promo on cros since cros users are logged
   // into sync already.
   return false;
 #else
 
   // Don't bother if we don't have any kind of network connection.
   if (net::NetworkChangeNotifier::IsOffline())
     return false;
 
-  // Don't show if the profile is an incognito.
-  if (profile->IsOffTheRecord())
-    return false;
-

[Roger Tawa OOO till Jul 10th, 2013/07/11 15:28:30]

Why do we need this check?  We don't suppress other sign in access points in
incognito.  Also, it seems from section "Behavior of the “Sign in” link", 2a, in
the design doc that incognito would be supported.

If we do want to suppress in incognito, maybe add a test for this case?

[fdoray, 2013/07/11 19:00:40]

SyncPromoUI::ShouldShowSyncPromo is used to determine if the bookmark sync promo
should be displayed. Removing this makes the sync promo visible in incognito, as
we want.

To my knowledge, SyncPromoUI::ShouldShowSyncPromo is never used in incognito
currently, so this change has no impact on existing code.
- If you install an extension from incognito, ExtensionInstalledBubble is
displayed in a normal browser.
- The incognito NTP doesn't even call SyncPromoUI::ShouldShowSyncPromo.

On 2013/07/11 15:28:30, Roger Tawa wrote:

   // Don't show for managed profiles.
   if (profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged))
     return false;
 
   // Display the signin promo if the user is not signed in.
   SigninManager* signin = SigninManagerFactory::GetForProfile(
       profile->GetOriginalProfile());
   return !signin->AuthInProgress() && signin->IsSigninAllowed() &&
       signin->GetAuthenticatedUsername().empty();
 #endif
@@ skipping 152 matching lines @@
   replacements.ClearQuery();
   const std::string& locale = g_browser_process->GetApplicationLocale();
   return url.ReplaceComponents(replacements) ==
       GURL(base::StringPrintf(kSyncLandingUrlPrefix, locale.c_str()));
 }
 
 // static
 void SyncPromoUI::ForceWebBasedSigninFlowForTesting(bool force) {
   g_force_web_based_signin_flow = force;
 }