Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 186023003: Speculative fix for crash in Canvas2DLayerBridge::freeReleasedMailbox (Closed)

Created:
6 years, 9 months ago by Justin Novosad
Modified:
6 years, 9 months ago
Reviewers:
Stephen White
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Speculative fix for crash in Canvas2DLayerBridge::freeReleasedMailbox BUG=348702 R=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168405

Patch Set 1 #

Total comments: 1

Patch Set 2 : Round 2 #

Patch Set 3 : try2 #

Patch Set 4 : fix layout test fail #

Patch Set 5 : removing unnecessary include #

Total comments: 1

Patch Set 6 : built a shed for my bike #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -32 lines) Patch
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 1 2 3 4 5 5 chunks +36 lines, -30 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Justin Novosad
PTAL
6 years, 9 months ago (2014-03-03 20:59:58 UTC) #1
Stephen White
https://codereview.chromium.org/186023003/diff/1/Source/platform/graphics/Canvas2DLayerBridge.cpp File Source/platform/graphics/Canvas2DLayerBridge.cpp (right): https://codereview.chromium.org/186023003/diff/1/Source/platform/graphics/Canvas2DLayerBridge.cpp#newcode334 Source/platform/graphics/Canvas2DLayerBridge.cpp:334: // Attempt to recover. Maybe we should just not ...
6 years, 9 months ago (2014-03-03 21:43:11 UTC) #2
Justin Novosad
On 2014/03/03 21:43:11, Stephen White wrote: > https://codereview.chromium.org/186023003/diff/1/Source/platform/graphics/Canvas2DLayerBridge.cpp > File Source/platform/graphics/Canvas2DLayerBridge.cpp (right): > > https://codereview.chromium.org/186023003/diff/1/Source/platform/graphics/Canvas2DLayerBridge.cpp#newcode334 ...
6 years, 9 months ago (2014-03-04 15:04:33 UTC) #3
Stephen White
https://codereview.chromium.org/186023003/diff/80001/Source/platform/graphics/Canvas2DImageBufferSurface.h File Source/platform/graphics/Canvas2DImageBufferSurface.h (right): https://codereview.chromium.org/186023003/diff/80001/Source/platform/graphics/Canvas2DImageBufferSurface.h#newcode58 Source/platform/graphics/Canvas2DImageBufferSurface.h:58: virtual bool isValid() const OVERRIDE { return m_layerBridge && ...
6 years, 9 months ago (2014-03-04 15:27:41 UTC) #4
Justin Novosad
On 2014/03/04 15:27:41, Stephen White wrote: > https://codereview.chromium.org/186023003/diff/80001/Source/platform/graphics/Canvas2DImageBufferSurface.h > File Source/platform/graphics/Canvas2DImageBufferSurface.h (right): > > https://codereview.chromium.org/186023003/diff/80001/Source/platform/graphics/Canvas2DImageBufferSurface.h#newcode58 ...
6 years, 9 months ago (2014-03-04 16:05:33 UTC) #5
Stephen White
LGTM
6 years, 9 months ago (2014-03-04 16:16:11 UTC) #6
Justin Novosad
The CQ bit was checked by junov@chromium.org
6 years, 9 months ago (2014-03-04 16:30:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/186023003/100001
6 years, 9 months ago (2014-03-04 16:30:14 UTC) #8
Justin Novosad
6 years, 9 months ago (2014-03-04 20:29:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 manually as r168405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698