Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: Source/platform/graphics/Canvas2DImageBufferSurface.h

Issue 186023003: Speculative fix for crash in Canvas2DLayerBridge::freeReleasedMailbox (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: removing unnecessary include Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 virtual ~Canvas2DImageBufferSurface() 49 virtual ~Canvas2DImageBufferSurface()
50 { 50 {
51 if (m_layerBridge) 51 if (m_layerBridge)
52 m_layerBridge->beginDestruction(); 52 m_layerBridge->beginDestruction();
53 } 53 }
54 54
55 // ImageBufferSurface implementation 55 // ImageBufferSurface implementation
56 virtual void willUse() OVERRIDE { m_layerBridge->willUse(); } 56 virtual void willUse() OVERRIDE { m_layerBridge->willUse(); }
57 virtual SkCanvas* canvas() const OVERRIDE { return m_layerBridge->canvas(); } 57 virtual SkCanvas* canvas() const OVERRIDE { return m_layerBridge->canvas(); }
58 virtual bool isValid() const OVERRIDE { return m_layerBridge && m_layerBridg e->isValid(); } 58 virtual bool isValid() const OVERRIDE { return m_layerBridge && (m_layerBrid ge->isValid() || m_layerBridge->tryRecover()); }
Stephen White 2014/03/04 15:27:41 <bikeshed>"tryRecover()" is a bit awkward. Maybe "
59 virtual blink::WebLayer* layer() const OVERRIDE { return m_layerBridge->laye r(); } 59 virtual blink::WebLayer* layer() const OVERRIDE { return m_layerBridge->laye r(); }
60 virtual Platform3DObject getBackingTexture() const OVERRIDE { return m_layer Bridge->getBackingTexture(); } 60 virtual Platform3DObject getBackingTexture() const OVERRIDE { return m_layer Bridge->getBackingTexture(); }
61 virtual bool isAccelerated() const OVERRIDE { return m_layerBridge->isAccele rated(); } 61 virtual bool isAccelerated() const OVERRIDE { return m_layerBridge->isAccele rated(); }
62 virtual void setIsHidden(bool hidden) OVERRIDE { m_layerBridge->setIsHidden( hidden); } 62 virtual void setIsHidden(bool hidden) OVERRIDE { m_layerBridge->setIsHidden( hidden); }
63 63
64 private: 64 private:
65 RefPtr<Canvas2DLayerBridge> m_layerBridge; 65 RefPtr<Canvas2DLayerBridge> m_layerBridge;
66 }; 66 };
67 67
68 } 68 }
69 69
70 #endif 70 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/platform/graphics/Canvas2DLayerBridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698