Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: pkg/analysis_server/test/domain_completion_test.dart

Issue 1860213002: Fix for issue 24555: import/export/part completion improvement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Comment from DanR Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index edce0d558bdf13cbaffe7d98a66ef56fa20c2e99..045d8d325ea2c427fbf218fccb16ca63e1a4f40f 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -140,10 +140,10 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
await getSuggestions();
expect(replacementOffset, completionOffset - 3);
expect(replacementLength, 3);
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'export',
- relevance: DART_RELEVANCE_HIGH);
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'import',
- relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'export \'\';',
+ selectionOffset: 8, relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'import \'\';',
+ selectionOffset: 8, relevance: DART_RELEVANCE_HIGH);
assertNoResult('extends');
assertNoResult('library');
}
@@ -174,12 +174,12 @@ class CompletionDomainHandlerTest extends AbstractCompletionDomainTest {
expect(replacementLength, 1);
assertHasResult(CompletionSuggestionKind.KEYWORD, 'library',
relevance: DART_RELEVANCE_HIGH);
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'import',
- relevance: DART_RELEVANCE_HIGH);
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'export',
- relevance: DART_RELEVANCE_HIGH);
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'part',
- relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'import \'\';',
+ selectionOffset: 8, relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'export \'\';',
+ selectionOffset: 8, relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'part \'\';',
+ selectionOffset: 6, relevance: DART_RELEVANCE_HIGH);
assertNoResult('extends');
}
@@ -353,8 +353,8 @@ class B extends A {
return getSuggestions().then((_) {
expect(replacementOffset, equals(completionOffset - 2));
expect(replacementLength, equals(2));
- assertHasResult(CompletionSuggestionKind.KEYWORD, 'export',
- relevance: DART_RELEVANCE_HIGH);
+ assertHasResult(CompletionSuggestionKind.KEYWORD, 'export \'\';',
+ selectionOffset: 8, relevance: DART_RELEVANCE_HIGH);
assertHasResult(CompletionSuggestionKind.KEYWORD, 'class',
relevance: DART_RELEVANCE_HIGH);
});

Powered by Google App Engine
This is Rietveld 408576698