Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: scripts/slave/recipes/skia/swarm_trigger.py

Issue 1859993003: Fix dimensions for Skia iOS Swarming bots (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: OS Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/skia/swarm_trigger.py
diff --git a/scripts/slave/recipes/skia/swarm_trigger.py b/scripts/slave/recipes/skia/swarm_trigger.py
index b0e7f841e880147f2eba4f96ca0b541cc168e7fb..0a4e7c89cf29bc3934e8cce1d350b508f2a22f1b 100644
--- a/scripts/slave/recipes/skia/swarm_trigger.py
+++ b/scripts/slave/recipes/skia/swarm_trigger.py
@@ -33,6 +33,7 @@ TEST_BUILDERS = {
'Build-Win8-MSVC-x86_64-Release-Swarming',
'Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming-Trybot',
'Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release-Swarming',
+ 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Swarming',
'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming',
'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming',
'Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Swarming',
@@ -79,6 +80,11 @@ def swarm_dimensions(builder_spec):
if 'Android' in builder_cfg['os']:
# For Android, the device type is a better dimension than CPU or GPU.
dimensions['product.board'] = builder_spec['product.board']
+ elif 'iOS' in builder_cfg['os']:
+ # For iOS, the device type is a better dimension than CPU or GPU.
+ dimensions['device'] = builder_spec['device_cfg']
+ # TODO(borenet): Replace this hack with something better.
+ dimensions['os'] = 'iOS-9.2'
elif builder_cfg['cpu_or_gpu'] == 'CPU':
dimensions['gpu'] = 'none'
# TODO(borenet): Add appropriate CPU dimension(s).

Powered by Google App Engine
This is Rietveld 408576698