Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: scripts/slave/recipes/skia/swarm_trigger.py

Issue 1859993003: Fix dimensions for Skia iOS Swarming bots (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: OS Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 5
6 # Recipe module for Skia Swarming trigger. 6 # Recipe module for Skia Swarming trigger.
7 7
8 8
9 import json 9 import json
10 10
(...skipping 15 matching lines...) Expand all
26 TEST_BUILDERS = { 26 TEST_BUILDERS = {
27 'client.skia.fyi': { 27 'client.skia.fyi': {
28 'skiabot-linux-housekeeper-003': [ 28 'skiabot-linux-housekeeper-003': [
29 'Build-Mac-Clang-x86_64-Release-Swarming', 29 'Build-Mac-Clang-x86_64-Release-Swarming',
30 'Build-Ubuntu-GCC-x86_64-Debug-Swarming', 30 'Build-Ubuntu-GCC-x86_64-Debug-Swarming',
31 'Build-Ubuntu-GCC-x86_64-Release-Swarming-Trybot', 31 'Build-Ubuntu-GCC-x86_64-Release-Swarming-Trybot',
32 'Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind', 32 'Build-Ubuntu-GCC-x86_64-Release-SwarmingValgrind',
33 'Build-Win8-MSVC-x86_64-Release-Swarming', 33 'Build-Win8-MSVC-x86_64-Release-Swarming',
34 'Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming-Trybot', 34 'Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Swarming-Trybot',
35 'Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release-Swarming', 35 'Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release-Swarming',
36 'Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release-Swarming',
36 'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming', 37 'Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release-Swarming',
37 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming', 38 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming',
38 'Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Swarming', 39 'Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release-Swarming',
39 'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-SwarmingValgrind', 40 'Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-SwarmingValgrind',
40 ], 41 ],
41 }, 42 },
42 } 43 }
43 44
44 45
45 def derive_compile_bot_name(builder_name, builder_spec): 46 def derive_compile_bot_name(builder_name, builder_spec):
(...skipping 26 matching lines...) Expand all
72 'pool': 'Skia', 73 'pool': 'Skia',
73 } 74 }
74 builder_cfg = builder_spec['builder_cfg'] 75 builder_cfg = builder_spec['builder_cfg']
75 dimensions['os'] = builder_cfg['os'] 76 dimensions['os'] = builder_cfg['os']
76 if 'Win' in builder_cfg['os']: 77 if 'Win' in builder_cfg['os']:
77 dimensions['os'] = 'Windows' # pragma: no cover 78 dimensions['os'] = 'Windows' # pragma: no cover
78 if builder_cfg['role'] in ('Test', 'Perf'): 79 if builder_cfg['role'] in ('Test', 'Perf'):
79 if 'Android' in builder_cfg['os']: 80 if 'Android' in builder_cfg['os']:
80 # For Android, the device type is a better dimension than CPU or GPU. 81 # For Android, the device type is a better dimension than CPU or GPU.
81 dimensions['product.board'] = builder_spec['product.board'] 82 dimensions['product.board'] = builder_spec['product.board']
83 elif 'iOS' in builder_cfg['os']:
84 # For iOS, the device type is a better dimension than CPU or GPU.
85 dimensions['device'] = builder_spec['device_cfg']
86 # TODO(borenet): Replace this hack with something better.
87 dimensions['os'] = 'iOS-9.2'
82 elif builder_cfg['cpu_or_gpu'] == 'CPU': 88 elif builder_cfg['cpu_or_gpu'] == 'CPU':
83 dimensions['gpu'] = 'none' 89 dimensions['gpu'] = 'none'
84 # TODO(borenet): Add appropriate CPU dimension(s). 90 # TODO(borenet): Add appropriate CPU dimension(s).
85 #dimensions['cpu'] = builder_cfg['cpu_or_gpu_value'] 91 #dimensions['cpu'] = builder_cfg['cpu_or_gpu_value']
86 else: # pragma: no cover 92 else: # pragma: no cover
87 # TODO: Create a dictionary of GPU name to device id when we have more 93 # TODO: Create a dictionary of GPU name to device id when we have more
88 # GPUs listed here. 94 # GPUs listed here.
89 if builder_cfg['cpu_or_gpu_value'] == 'GTX550Ti': 95 if builder_cfg['cpu_or_gpu_value'] == 'GTX550Ti':
90 dimensions['gpu'] = '10de:1244' 96 dimensions['gpu'] = '10de:1244'
91 else: 97 else:
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming' 436 builder = 'Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Swarming'
431 master = 'client.skia' 437 master = 'client.skia'
432 slave = 'skiabot-linux-test-000' 438 slave = 'skiabot-linux-test-000'
433 test = test_for_bot(api, builder, master, slave, 'No_downloaded_SKP_VERSION') 439 test = test_for_bot(api, builder, master, slave, 'No_downloaded_SKP_VERSION')
434 test += api.step_data('Get downloaded SKP_VERSION', retcode=1) 440 test += api.step_data('Get downloaded SKP_VERSION', retcode=1)
435 test += api.path.exists( 441 test += api.path.exists(
436 api.path['slave_build'].join('skia'), 442 api.path['slave_build'].join('skia'),
437 api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt') 443 api.path['slave_build'].join('tmp', 'uninteresting_hashes.txt')
438 ) 444 )
439 yield test 445 yield test
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698