Issue 185993009: Reland r254672.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 185993009: Reland r254672. (Closed)

Created:
6 years, 9 months ago by wtc

Modified:
6 years, 9 months ago

Reviewers:
rlarocque, eroman, stgao

CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, haitaol+watch_chromium.org, frankf, stgao, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Reland r254672. Replace the custom ProxyConfigServiceDirect class with the equivalent net::ProxyConfigServiceFixed class. Original code review: https://codereview.chromium.org/180283003 TBR=eroman@chromium.org,stgao@chromium.org,rlarocque@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255160

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -38 lines)			Patch
	M	chrome/test/chromedriver/net/url_request_context_getter.cc	View		2 chunks	+3 lines, -19 lines	0 comments	Download
	M	sync/test/accounts_client/url_request_context_getter.cc	View		2 chunks	+3 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/185993009/10001

6 years, 9 months ago (2014-03-05 19:09:29 UTC) #3

Message was sent while issue was closed.

Change committed as 255160

Expand Messages | Collapse Messages