Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 180283003: Replace the custom ProxyConfigServiceDirect class with the equivalent (Closed)

Created:
6 years, 10 months ago by wtc
Modified:
6 years, 9 months ago
Reviewers:
stgao, eroman, rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, haitaol+watch_chromium.org, frankf, stgao, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Replace the custom ProxyConfigServiceDirect class with the equivalent net::ProxyConfigServiceFixed class. R=eroman@chromium.org,stgao@chromium.org,rlarocque@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254672

Patch Set 1 #

Patch Set 2 : Sync with tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -38 lines) Patch
M chrome/test/chromedriver/net/url_request_context_getter.cc View 1 2 chunks +3 lines, -19 lines 0 comments Download
M sync/test/accounts_client/url_request_context_getter.cc View 1 2 chunks +3 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
wtc
6 years, 10 months ago (2014-02-25 20:26:42 UTC) #1
eroman
lgtm
6 years, 10 months ago (2014-02-25 20:33:28 UTC) #2
stgao
lgtm
6 years, 10 months ago (2014-02-25 20:53:36 UTC) #3
wtc
Richard: please review this CL. Thanks.
6 years, 9 months ago (2014-02-27 18:07:29 UTC) #4
rlarocque
lgtm
6 years, 9 months ago (2014-02-28 18:10:31 UTC) #5
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 9 months ago (2014-03-03 16:00:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/180283003/1
6 years, 9 months ago (2014-03-03 16:00:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/180283003/1
6 years, 9 months ago (2014-03-03 17:31:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 17:37:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel
6 years, 9 months ago (2014-03-03 17:37:59 UTC) #10
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 9 months ago (2014-03-03 23:49:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/180283003/20001
6 years, 9 months ago (2014-03-03 23:52:49 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 05:34:16 UTC) #13
Message was sent while issue was closed.
Change committed as 254672

Powered by Google App Engine
This is Rietveld 408576698