Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: ppapi/api/pp_var.idl

Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix tests; slightly better behaviour if user passes a resource to a message. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/api/pp_var.idl
diff --git a/ppapi/api/pp_var.idl b/ppapi/api/pp_var.idl
index fda2332b895509588ce700ab551fec8c921a3709..6938da0de8c58c74c9fd98aa45a4c17c88024fdc 100644
--- a/ppapi/api/pp_var.idl
+++ b/ppapi/api/pp_var.idl
@@ -70,7 +70,14 @@ enum PP_VarType {
* contiguously. See PPB_VarArrayBuffer_Dev for functions special to
* ArrayBuffer vars.
*/
- PP_VARTYPE_ARRAY_BUFFER = 9
+ PP_VARTYPE_ARRAY_BUFFER = 9,
+
+ /**
+ * Resources are not currently supported but will be added in future
+ * revisions. These objects are reference counted, so AddRef and Release must
+ * be used properly to avoid memory leaks.
+ */
+ PP_VARTYPE_RESOURCE = 10
};
@@ -102,8 +109,8 @@ enum PP_VarType {
/**
* If <code>type</code> is <code>PP_VARTYPE_STRING</code>,
- * <code>PP_VARTYPE_OBJECT</code>, <code>PP_VARTYPE_ARRAY</code>, or
- * <code>PP_VARTYPE_DICTIONARY</code>,
+ * <code>PP_VARTYPE_OBJECT</code>, <code>PP_VARTYPE_ARRAY</code>,
yzshen1 2013/09/03 20:19:53 Please also add PP_VARTYPE_ARRAY_BUFFER here.
Matt Giuca 2013/09/10 01:17:13 Done.
+ * <code>PP_VARTYPE_DICTIONARY</code>, or <code>PP_VARTYPE_RESOURCE</code>,
* <code>as_id</code> represents the value of this <code>PP_Var</code> as
* an opaque handle assigned by the browser. This handle is guaranteed
* never to be 0, so a module can initialize this ID to 0 to indicate a

Powered by Google App Engine
This is Rietveld 408576698