content/renderer/pepper/v8_var_converter.cc - Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/v8_var_converter.cc

Issue 18599005: [PPAPI] Added PP_VARTYPE_RESOURCE as a PP_VarType enum value. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix tests; slightly better behaviour if user passes a resource to a message. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/pepper/v8_var_converter.cc

diff --git a/content/renderer/pepper/v8_var_converter.cc b/content/renderer/pepper/v8_var_converter.cc

index 38447a8f1bc987e0e3d81c257e45a88c61134550..b0843d448cbe344ad601ec49b62b0ade0e00b68b 100644

--- a/content/renderer/pepper/v8_var_converter.cc

+++ b/content/renderer/pepper/v8_var_converter.cc

@@ -148,6 +148,7 @@ bool GetOrCreateV8Value(const PP_Var& var,

*result = v8::Object::New();

break;

case PP_VARTYPE_OBJECT:

+ case PP_VARTYPE_RESOURCE:

dmichael (off chromium) 2013/09/03 16:25:17 It would be nice to add a TODO and reference the b

Matt Giuca 2013/09/10 01:17:13 Done.

NOTREACHED();

result->Clear();

return false;