Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859763005: [crankshaft] Fix environment handling after leaving inlined tail call. (Closed)

Created:
4 years, 8 months ago by Igor Sheludko
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix environment handling after leaving inlined tail call. BUG=chromium:537444, v8:4698 LOG=N TBR=bmeurer@chromium.org Committed: https://crrev.com/792bf2a0933ded1b66f1db219be7f27fe8b9ad99 Cr-Commit-Position: refs/heads/master@{#35253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/crankshaft/hydrogen.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/crankshaft/lithium.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-537444.js View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859763005/1
4 years, 8 months ago (2016-04-05 09:10:40 UTC) #2
Igor Sheludko
PTAL
4 years, 8 months ago (2016-04-05 09:10:58 UTC) #4
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-05 09:11:26 UTC) #6
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-05 09:21:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 09:38:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859763005/1
4 years, 8 months ago (2016-04-05 09:39:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 09:42:32 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 09:44:05 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/792bf2a0933ded1b66f1db219be7f27fe8b9ad99
Cr-Commit-Position: refs/heads/master@{#35253}

Powered by Google App Engine
This is Rietveld 408576698