Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: src/crankshaft/lithium.cc

Issue 1859763005: [crankshaft] Fix environment handling after leaving inlined tail call. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/lithium.h" 5 #include "src/crankshaft/lithium.h"
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 8
9 #if V8_TARGET_ARCH_IA32 9 #if V8_TARGET_ARCH_IA32
10 #include "src/crankshaft/ia32/lithium-ia32.h" // NOLINT 10 #include "src/crankshaft/ia32/lithium-ia32.h" // NOLINT
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 505
506 void LChunkBuilderBase::Retry(BailoutReason reason) { 506 void LChunkBuilderBase::Retry(BailoutReason reason) {
507 info()->RetryOptimization(reason); 507 info()->RetryOptimization(reason);
508 status_ = ABORTED; 508 status_ = ABORTED;
509 } 509 }
510 510
511 LInstruction* LChunkBuilderBase::AssignEnvironment(LInstruction* instr, 511 LInstruction* LChunkBuilderBase::AssignEnvironment(LInstruction* instr,
512 HEnvironment* hydrogen_env) { 512 HEnvironment* hydrogen_env) {
513 int argument_index_accumulator = 0; 513 int argument_index_accumulator = 0;
514 ZoneList<HValue*> objects_to_materialize(0, zone()); 514 ZoneList<HValue*> objects_to_materialize(0, zone());
515 DCHECK_NE(TAIL_CALLER_FUNCTION, hydrogen_env->frame_type());
515 instr->set_environment(CreateEnvironment( 516 instr->set_environment(CreateEnvironment(
516 hydrogen_env, &argument_index_accumulator, &objects_to_materialize)); 517 hydrogen_env, &argument_index_accumulator, &objects_to_materialize));
517 return instr; 518 return instr;
518 } 519 }
519 520
520 LEnvironment* LChunkBuilderBase::CreateEnvironment( 521 LEnvironment* LChunkBuilderBase::CreateEnvironment(
521 HEnvironment* hydrogen_env, int* argument_index_accumulator, 522 HEnvironment* hydrogen_env, int* argument_index_accumulator,
522 ZoneList<HValue*>* objects_to_materialize) { 523 ZoneList<HValue*>* objects_to_materialize) {
523 if (hydrogen_env == NULL) return NULL; 524 if (hydrogen_env == NULL) return NULL;
524 525
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 674
674 LPhase::~LPhase() { 675 LPhase::~LPhase() {
675 if (ShouldProduceTraceOutput()) { 676 if (ShouldProduceTraceOutput()) {
676 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 677 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
677 } 678 }
678 } 679 }
679 680
680 681
681 } // namespace internal 682 } // namespace internal
682 } // namespace v8 683 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698