Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 1859633002: [Autofill] Fix heuristics to detect cc-number on united.com. (Closed)

Created:
4 years, 8 months ago by Justin Donnelly
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Autofill] Fix heuristics to detect cc-number on united.com. The reason was that one of the cc-number fields has type="password", and we didn't support this type for cc-number fields. BUG=591166, 598873 Review URL: https://codereview.chromium.org/1754793003 Cr-Commit-Position: refs/heads/master@{#379287} (cherry picked from commit d5a83da5b2571eeb25b61f4b4bd6424b0695fb33) Committed: https://chromium.googlesource.com/chromium/src/+/71634987bfffd49d609d37ae4a9747c17b6e291e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+934 lines, -3 lines) Patch
A chrome/test/data/autofill/heuristics/input/138_cc_checkout_united.com.html View 1 chunk +876 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out View 1 chunk +54 lines, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
Justin Donnelly
4 years, 8 months ago (2016-04-04 17:34:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71634987bfffd49d609d37ae4a9747c17b6e291e (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698