[Autofill] Fix heuristics to detect cc-number on united.com.

[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we didn't support this type for cc-number fields.

BUG=591166
Committed: https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33
Cr-Commit-Position: refs/heads/master@{#379287}

[sebsg, 2016-03-01 21:29:31]

Patchset #1 (id:1) has been deleted

[sebsg, 2016-03-01 21:43:44]

Patchset #1 (id:20001) has been deleted

[sebsg, 2016-03-01 21:44:28]

Description was changed from

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166
==========

to

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166
==========

[sebsg, 2016-03-01 21:44:28]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2016-03-01 21:44:56]

Hi Math, do you see any issue with this? Thanks.

[Mathieu, 2016-03-02 19:24:04]

lgtm

https://codereview.chromium.org/1754793003/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1754793003/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:140: if
(ParseFieldSpecifics(scanner, base::UTF8ToUTF16(kCardNumberRe),
Let's put a TODO with a crbug to revisit this in the short term.

[sebsg, 2016-03-03 22:34:01]

Added the TODO. Thanks!

https://codereview.chromium.org/1754793003/diff/40001/components/autofill/cor...
File components/autofill/core/browser/credit_card_field.cc (right):

https://codereview.chromium.org/1754793003/diff/40001/components/autofill/cor...
components/autofill/core/browser/credit_card_field.cc:140: if
(ParseFieldSpecifics(scanner, base::UTF8ToUTF16(kCardNumberRe),
On 2016/03/02 19:24:04, Mathieu Perreault wrote:
> Let's put a TODO with a crbug to revisit this in the short term.

Done.

[sebsg, 2016-03-04 15:14:56]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2016-03-04 15:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org
Link to the patchset: https://codereview.chromium.org/1754793003/#ps80001
(title: "Added TODO")

[commit-bot: I haz the power, 2016-03-04 15:15:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1754793003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1754793003/80001

[commit-bot: I haz the power, 2016-03-04 15:22:53]

Description was changed from

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166
==========

to

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166
==========

[commit-bot: I haz the power, 2016-03-04 15:22:54]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-04 15:24:09]

Description was changed from

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166
==========

to

==========
[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we
didn't support this type for cc-number fields.

BUG=591166

Committed: https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33
Cr-Commit-Position: refs/heads/master@{#379287}
==========

[commit-bot: I haz the power, 2016-03-04 15:24:09]

Patchset 3 (id:??) landed as
https://crrev.com/d5a83da5b2571eeb25b61f4b4bd6424b0695fb33
Cr-Commit-Position: refs/heads/master@{#379287}