Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1859593003: Revert of Fix HistoryEntry corruption when commit isn't for provisional entry. (Closed)

Created:
4 years, 8 months ago by Charlie Reis
Modified:
4 years, 8 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, alexmos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix HistoryEntry corruption when commit isn't for provisional entry. (patchset #2 id:20001 of https://codereview.chromium.org/1848103004/ ) Reason for revert: This led to crashes in HistoryController::UpdateForCommit if there is no current entry and the provisional entry doesn't match the commit. See https://crbug.com/600238. I'll land an updated fix. Original issue's description: > Fix HistoryEntry corruption when commit isn't for provisional entry. > > BUG=597322 > TEST=See bug for repro steps. > > Committed: https://crrev.com/bb3548ef2fcdb58f9bc638bb5a3c379320fdd0e0 > Cr-Commit-Position: refs/heads/master@{#384659} TBR=japhet@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=597322 Committed: https://crrev.com/413fc09a3fa2e915410d39034d78661837468633 Cr-Commit-Position: refs/heads/master@{#384938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M content/renderer/history_controller.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Charlie Reis
Created Revert of Fix HistoryEntry corruption when commit isn't for provisional entry.
4 years, 8 months ago (2016-04-04 16:29:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859593003/1
4 years, 8 months ago (2016-04-04 16:29:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859593003/1
4 years, 8 months ago (2016-04-04 16:31:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859593003/1
4 years, 8 months ago (2016-04-04 17:01:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1859593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1859593003/1
4 years, 8 months ago (2016-04-04 17:32:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 17:43:53 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:45:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/413fc09a3fa2e915410d39034d78661837468633
Cr-Commit-Position: refs/heads/master@{#384938}

Powered by Google App Engine
This is Rietveld 408576698