Chromium Code Reviews Chromium Code Reviews
Issue 185943004:
DevTools: Do not save split view size on show mode changes. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/inspector/split-view.html |
| diff --git a/LayoutTests/inspector/split-view.html b/LayoutTests/inspector/split-view.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..21f57db291a284146c57eecc6016e36cc4b35bf7 |
| --- /dev/null |
| +++ b/LayoutTests/inspector/split-view.html |
| @@ -0,0 +1,121 @@ |
| +<html> |
| +<head> |
| +<script src="../http/tests/inspector/inspector-test.js"></script> |
| +<script> |
| + |
| +function test() |
| +{ |
| + var settingIndex = 0; |
| + function createAndShowSplitView(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, useDip, shouldSaveShowMode) |
| + { |
| + var splitView = new WebInspector.SplitView(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, useDip); |
| + if (shouldSaveShowMode) |
| + splitView.enableShowModeSaving(); |
| + splitView.element.style.position = "absolute"; |
| + splitView.element.style.top = "0"; |
| + splitView.element.style.left = "0"; |
| + splitView.element.style.height = "500px"; |
| + splitView.element.style.width = "500px"; |
| + splitView.show(WebInspector.inspectorView.element); |
|
dgozman
2014/03/06 17:53:35
Why not markAsRoot and show in document.body?
|
| + return splitView; |
| + } |
| + |
| + function dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + { |
| + var sidebarSize = splitView.isVertical() ? splitView.sidebarElement().offsetWidth : splitView.sidebarElement().offsetHeight; |
| + var orientation = splitView.isVertical() ? "vertical" : "horizontal"; |
| + InspectorTest.addResult(" Sidebar size = " + sidebarSize + ", showMode = " + splitView.showMode() + ", " + orientation); |
|
dgozman
2014/03/06 17:53:35
Don't you want to dump the setting value too, to e
|
| +// InspectorTest.addResult(" _preferredSidebarSize = " + splitView._preferredSidebarSize); |
|
dgozman
2014/03/06 17:53:35
commented code
|
| + } |
| + |
| + function testSplitViewSizes(useFraction, shouldSaveShowMode) |
| + { |
| + var secondIsSidebar = true; |
| + var settingName = "splitViewStateSettingName" + (++settingIndex); |
| + var defaultSidebarWidth = useFraction ? 0.23 : 101; |
| + var defaultSidebarHeight = useFraction ? 0.24 : 102; |
| + var newWidth = useFraction ? 125 : 201; |
| + var newHeight = useFraction ? 130 : 202; |
| + |
| + var splitView; |
| + InspectorTest.addResult("Create default split view"); |
| + var params = "useFraction = " + useFraction + ", shouldSaveShowMode = " + shouldSaveShowMode; |
| + InspectorTest.addResult("Running split view test with the following parameters: " + params); |
| + |
| + InspectorTest.addResult("Creating split view"); |
| + splitView = createAndShowSplitView(true, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
|
dgozman
2014/03/06 17:53:35
nit: semicolon is missing here and below
|
| + |
| + InspectorTest.addResult("Hiding sidebar"); |
| + splitView.hideSidebar(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Showing sidebar"); |
| + splitView.showBoth(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Resizing"); |
| + splitView.setSidebarSize(newWidth); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Hiding sidebar"); |
| + splitView.hideSidebar(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Showing sidebar"); |
| + splitView.showBoth(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Making horizontal"); |
| + splitView.setVertical(false); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Resizing"); |
| + splitView.setSidebarSize(newHeight); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Hiding sidebar"); |
| + splitView.hideSidebar(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + splitView.element.remove(); |
| + |
| + InspectorTest.addResult("Recreating split view"); |
| + splitView = createAndShowSplitView(true, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Hiding sidebar"); |
| + splitView.hideSidebar(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Making horizontal"); |
| + splitView.setVertical(false); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + InspectorTest.addResult("Showing sidebar"); |
| + splitView.showBoth(); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + splitView.element.remove(); |
| + |
| + InspectorTest.addResult("Recreating split view"); |
| + splitView = createAndShowSplitView(true, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); |
| + dumpSplitViewOrientationShowModeAndSidebarSize(splitView) |
| + |
| + splitView.element.remove(); |
| + InspectorTest.addResult(""); |
| + } |
| + |
| + // Test all combinations of useFraction and shouldSaveShowMode flags |
| + testSplitViewSizes(false, false); |
| + testSplitViewSizes(false, true); |
| + testSplitViewSizes(true, false); |
| + testSplitViewSizes(true, true); |
| + InspectorTest.completeTest(); |
| +} |
| +</script> |
| +</head> |
| +<body onload="runTest()"> |
| +<p>Tests hpw split view saving to settings works.</p> |
|
dgozman
2014/03/06 17:53:35
typo: hpw
|
| +</body> |
| +</html> |
