Chromium Code Reviews Chromium Code Reviews
Issue 185943004:
DevTools: Do not save split view size on show mode changes. (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <html> | |
| 2 <head> | |
| 3 <script src="../http/tests/inspector/inspector-test.js"></script> | |
| 4 <script> | |
| 5 | |
| 6 function test() | |
| 7 { | |
| 8 var settingIndex = 0; | |
| 9 function createAndShowSplitView(isVertical, secondIsSidebar, settingName, de faultSidebarWidth, defaultSidebarHeight, useDip, shouldSaveShowMode) | |
| 10 { | |
| 11 var splitView = new WebInspector.SplitView(isVertical, secondIsSidebar, settingName, defaultSidebarWidth, defaultSidebarHeight, useDip); | |
| 12 if (shouldSaveShowMode) | |
| 13 splitView.enableShowModeSaving(); | |
| 14 splitView.element.style.position = "absolute"; | |
| 15 splitView.element.style.top = "0"; | |
| 16 splitView.element.style.left = "0"; | |
| 17 splitView.element.style.height = "500px"; | |
| 18 splitView.element.style.width = "500px"; | |
| 19 splitView.show(WebInspector.inspectorView.element); | |
|
dgozman
2014/03/06 17:53:35
Why not markAsRoot and show in document.body?
| |
| 20 return splitView; | |
| 21 } | |
| 22 | |
| 23 function dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 24 { | |
| 25 var sidebarSize = splitView.isVertical() ? splitView.sidebarElement().of fsetWidth : splitView.sidebarElement().offsetHeight; | |
| 26 var orientation = splitView.isVertical() ? "vertical" : "horizontal"; | |
| 27 InspectorTest.addResult(" Sidebar size = " + sidebarSize + ", showMod e = " + splitView.showMode() + ", " + orientation); | |
|
dgozman
2014/03/06 17:53:35
Don't you want to dump the setting value too, to e
| |
| 28 // InspectorTest.addResult(" _preferredSidebarSize = " + splitView._p referredSidebarSize); | |
|
dgozman
2014/03/06 17:53:35
commented code
| |
| 29 } | |
| 30 | |
| 31 function testSplitViewSizes(useFraction, shouldSaveShowMode) | |
| 32 { | |
| 33 var secondIsSidebar = true; | |
| 34 var settingName = "splitViewStateSettingName" + (++settingIndex); | |
| 35 var defaultSidebarWidth = useFraction ? 0.23 : 101; | |
| 36 var defaultSidebarHeight = useFraction ? 0.24 : 102; | |
| 37 var newWidth = useFraction ? 125 : 201; | |
| 38 var newHeight = useFraction ? 130 : 202; | |
| 39 | |
| 40 var splitView; | |
| 41 InspectorTest.addResult("Create default split view"); | |
| 42 var params = "useFraction = " + useFraction + ", shouldSaveShowMode = " + shouldSaveShowMode; | |
| 43 InspectorTest.addResult("Running split view test with the following para meters: " + params); | |
| 44 | |
| 45 InspectorTest.addResult("Creating split view"); | |
| 46 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); | |
| 47 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
|
dgozman
2014/03/06 17:53:35
nit: semicolon is missing here and below
| |
| 48 | |
| 49 InspectorTest.addResult("Hiding sidebar"); | |
| 50 splitView.hideSidebar(); | |
| 51 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 52 | |
| 53 InspectorTest.addResult("Showing sidebar"); | |
| 54 splitView.showBoth(); | |
| 55 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 56 | |
| 57 InspectorTest.addResult("Resizing"); | |
| 58 splitView.setSidebarSize(newWidth); | |
| 59 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 60 | |
| 61 InspectorTest.addResult("Hiding sidebar"); | |
| 62 splitView.hideSidebar(); | |
| 63 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 64 | |
| 65 InspectorTest.addResult("Showing sidebar"); | |
| 66 splitView.showBoth(); | |
| 67 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 68 | |
| 69 InspectorTest.addResult("Making horizontal"); | |
| 70 splitView.setVertical(false); | |
| 71 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 72 | |
| 73 InspectorTest.addResult("Resizing"); | |
| 74 splitView.setSidebarSize(newHeight); | |
| 75 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 76 | |
| 77 InspectorTest.addResult("Hiding sidebar"); | |
| 78 splitView.hideSidebar(); | |
| 79 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 80 | |
| 81 splitView.element.remove(); | |
| 82 | |
| 83 InspectorTest.addResult("Recreating split view"); | |
| 84 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); | |
| 85 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 86 | |
| 87 InspectorTest.addResult("Hiding sidebar"); | |
| 88 splitView.hideSidebar(); | |
| 89 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 90 | |
| 91 InspectorTest.addResult("Making horizontal"); | |
| 92 splitView.setVertical(false); | |
| 93 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 94 | |
| 95 InspectorTest.addResult("Showing sidebar"); | |
| 96 splitView.showBoth(); | |
| 97 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 98 | |
| 99 splitView.element.remove(); | |
| 100 | |
| 101 InspectorTest.addResult("Recreating split view"); | |
| 102 splitView = createAndShowSplitView(true, secondIsSidebar, settingName, d efaultSidebarWidth, defaultSidebarHeight, false, shouldSaveShowMode); | |
| 103 dumpSplitViewOrientationShowModeAndSidebarSize(splitView) | |
| 104 | |
| 105 splitView.element.remove(); | |
| 106 InspectorTest.addResult(""); | |
| 107 } | |
| 108 | |
| 109 // Test all combinations of useFraction and shouldSaveShowMode flags | |
| 110 testSplitViewSizes(false, false); | |
| 111 testSplitViewSizes(false, true); | |
| 112 testSplitViewSizes(true, false); | |
| 113 testSplitViewSizes(true, true); | |
| 114 InspectorTest.completeTest(); | |
| 115 } | |
| 116 </script> | |
| 117 </head> | |
| 118 <body onload="runTest()"> | |
| 119 <p>Tests hpw split view saving to settings works.</p> | |
|
dgozman
2014/03/06 17:53:35
typo: hpw
| |
| 120 </body> | |
| 121 </html> | |
| OLD | NEW |
