third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html - Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a comment line Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-outscope-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

index 5a6a447d29f97661486085fdddd06bec21010833..4aae0086f246288cc60f1c0550c8c1108e513630 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

@@ -14,7 +14,7 @@ t.step(function() {

return wait_for_state(t, registration.installing, 'activated');

}))

.then(t.step_func(function() {

- return with_iframe(scope)

+ return with_iframe(scope, true);

nhiroki 2016/04/07 05:37:18 |IFRAME_RECLAMATION.TRUE| is the default behavior,

shimazu (google) 2016/04/07 06:53:55 Done.

}))

.then(t.step_func(function(frame) {

var w = frame.contentWindow;