third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html - Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-load.html

Issue 1859343002: ServiceWorker: Remove iframes explicitly after a test is finished (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove a comment line Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/fetch-mixed-content-to-outscope-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/test-helpers.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Service Worker: Controller on load</title>	2 <title>Service Worker: Controller on load</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="resources/test-helpers.js"></script>	5 <script src="resources/test-helpers.js"></script>

6 <body>	6 <body>

7 <script>	7 <script>

8 var t = async_test('controller is set for a controlled document');	8 var t = async_test('controller is set for a controlled document');

9 t.step(function() {	9 t.step(function() {

10 var url = 'resources/empty-worker.js';	10 var url = 'resources/empty-worker.js';

11 var scope = 'resources/blank.html';	11 var scope = 'resources/blank.html';

12 service_worker_unregister_and_register(t, url, scope)	12 service_worker_unregister_and_register(t, url, scope)

13 .then(t.step_func(function(registration) {	13 .then(t.step_func(function(registration) {

14 return wait_for_state(t, registration.installing, 'activated');	14 return wait_for_state(t, registration.installing, 'activated');

15 }))	15 }))

16 .then(t.step_func(function() {	16 .then(t.step_func(function() {

17 return with_iframe(scope)	17 return with_iframe(scope, true);
	nhiroki 2016/04/07 05:37:18 \|IFRAME_RECLAMATION.TRUE\| is the default behavior, \|IFRAME_RECLAMATION.TRUE\| is the default behavior, so we don't have to pass \|true\| here and elsewhere. shimazu (google) 2016/04/07 06:53:55 Done. Show quoted text On 2016/04/07 05:37:18, nhiroki wrote: > \|IFRAME_RECLAMATION.TRUE\| is the default behavior, so we don't have to pass > \|true\| here and elsewhere. Done.
18 }))	18 }))

19 .then(t.step_func(function(frame) {	19 .then(t.step_func(function(frame) {

20 var w = frame.contentWindow;	20 var w = frame.contentWindow;

21 var controller = w.navigator.serviceWorker.controller;	21 var controller = w.navigator.serviceWorker.controller;

22 assert_true(controller instanceof w.ServiceWorker,	22 assert_true(controller instanceof w.ServiceWorker,

23 'controller should be a ServiceWorker object');	23 'controller should be a ServiceWorker object');

24 assert_equals(controller.scriptURL, normalizeURL(url));	24 assert_equals(controller.scriptURL, normalizeURL(url));

25 service_worker_unregister_and_done(t, scope);	25 service_worker_unregister_and_done(t, scope);

26 }))	26 }))

27 .catch(unreached_rejection(t));	27 .catch(unreached_rejection(t));

28 });	28 });

29 </script>	29 </script>

30 </body>	30 </body>

OLD	NEW