Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 18593003: Disable mouse-focus of buttons in some WebUI pages (Closed)

Created:
7 years, 5 months ago by tkent
Modified:
5 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, dmazzoni
Visibility:
Public.

Description

Disable mouse-focus of buttons in some WebUI pages. Introduce FocusManager.disableMouseFocusOnButtons, and use it in uber navigation, options, history, and NTP. This is a follow-up change for the fix for crbug.com/89708. BUG=255405, 255973, 256590 R=arv@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210973

Patch Set 1 #

Patch Set 2 : Add a public function to FocusManager #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M chrome/browser/resources/history/history.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/history/history.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber_frame.html View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/uber/uber_frame.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/js/cr/ui/focus_manager.js View 1 1 chunk +26 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tkent
We need to disable mouse-focus globally. Not all pages use focus_manager.js. Should we put the ...
7 years, 5 months ago (2013-07-03 01:16:20 UTC) #1
arv (Not doing code reviews)
I don't like making this change globally. It kind of defeats the purpose of fixing ...
7 years, 5 months ago (2013-07-08 18:32:14 UTC) #2
tkent
On 2013/07/08 18:32:14, arv wrote: > I don't like making this change globally. It kind ...
7 years, 5 months ago (2013-07-08 23:51:19 UTC) #3
arv (Not doing code reviews)
LGTM
7 years, 5 months ago (2013-07-10 20:56:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/18593003/7002
7 years, 5 months ago (2013-07-10 20:58:47 UTC) #5
tkent
Committed patchset #2 manually as r210973 (presubmit successful).
7 years, 5 months ago (2013-07-10 23:56:00 UTC) #6
Dan Beam
5 years, 10 months ago (2015-02-06 20:20:49 UTC) #8
Message was sent while issue was closed.
On 2013/07/08 18:32:14, arv wrote:
> I don't like making this change globally. It kind of defeats the purpose of
> fixing this in the first place.
> 
> How about exposing the code that preventsDefault as a method on the
FocusManager
> and then the WebUI pages that depend on this legacy behavior can opt in by
doing
> something like
> 
> new FocusManager().disableMouseFocusOnInputs()

why do webui pages depend on buttons not getting focus?  i don't see a real
issue with all the bugs this fixes... and so far this code has just been messing
with chrome://* accessibility.

Powered by Google App Engine
This is Rietveld 408576698