third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h - Issue 1859293002: [DevTools] Move Console to v8_inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/timing/ConsoleMemory.idl ('K') | « third_party/WebKit/Source/platform/blink_platform.gypi ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Console.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h b/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

index b48162ca562a0f66823cf1442f46d2d63675c451..52508d4ed6f9b9df7648d6089f3e69c7f7d0be72 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

@@ -39,7 +39,7 @@ public:

~String16() { }

static String16 number(int i) { return String::number(i); }

- static String16 fromDouble(double number) { return Decimal::fromDouble(number).toString(); }

+ static String16 fromDouble(double number, int precision = -1) { return precision == -1 ? Decimal::fromDouble(number).toString() : String::numberToStringFixedWidth(number, precision); }

dgozman 2016/04/08 18:18:46 Let's do a separate method fromDoubleFixedWidth.

kozy 2016/04/08 23:56:51 Done.

size_t length() const { return m_impl.length(); }

bool isEmpty() const { return m_impl.isEmpty(); }