Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added missing tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
index e85c36ce26cca0fe33011e739ac52b40cfc0b526..cb325966033d1ed958ad3186c15f9e77d6359263 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h
@@ -48,6 +48,7 @@ struct ScriptBreakpoint;
class InspectedContext;
class V8DebuggerAgentImpl;
class V8InspectorSessionImpl;
+class V8ProfilerAgentImpl;
class V8RuntimeAgentImpl;
class V8DebuggerImpl : public V8Debugger {
@@ -119,6 +120,7 @@ public:
const ContextByIdMap* contextGroup(int contextGroupId);
void disconnect(V8InspectorSessionImpl*);
+ V8ProfilerAgentImpl* findEnabledProfilerAgent(v8::Local<v8::Context>);
dgozman 2016/04/12 03:32:16 Let's move this method to call site.
kozy 2016/04/12 21:58:32 Done.
private:
void enable();
void disable();
@@ -141,6 +143,7 @@ private:
v8::Local<v8::String> v8InternalizedString(const char*) const;
void handleV8AsyncTaskEvent(V8DebuggerAgentImpl*, v8::Local<v8::Context>, v8::Local<v8::Object> executionState, v8::Local<v8::Object> eventData);
+ bool installConsole(v8::Local<v8::Context>, bool hasMemoryAttribute);
v8::Isolate* m_isolate;
V8DebuggerClient* m_client;

Powered by Google App Engine
This is Rietveld 408576698