Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added missing tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
index 598b08a59000f045944b179ae0161005a81746ff..af82f87691e732b7f201805a1123339f1248edb2 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
@@ -59,6 +59,10 @@ public:
bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
int ensureDefaultContextInGroup(int contextGroupId) override;
+ v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>, v8::Local<v8::Object> creationContext) override { return v8::MaybeLocal<v8::Value>(); }
dgozman 2016/04/12 03:32:15 Move to cpp. Add ASSERT_NOT_REACHED.
kozy 2016/04/12 21:58:32 Done.
+protected:
+ void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*);
+
private:
WorkerThread* m_workerThread;
};

Powered by Google App Engine
This is Rietveld 408576698