Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added missing tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 9fb7632c0b152504152d2b219019d5f0282029ef..2b08a9a096c7ee52a7c677ade977d5d4cee91b79 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -14,6 +14,7 @@
namespace blink {
+class ConsoleMessage;
class WorkerThread;
class CORE_EXPORT ThreadDebugger : public V8DebuggerClient {
@@ -32,7 +33,15 @@ public:
V8Debugger* debugger() const { return m_debugger.get(); }
virtual bool isWorker() { return true; }
+ void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const v8::FunctionCallbackInfo<v8::Value>& arguments, unsigned skipArgumentCount) final;
dgozman 2016/04/12 03:32:15 Move these to "V8DebuggerClient implementation" bl
kozy 2016/04/12 21:58:32 Done.
+ void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& text) final;
+
+ void consoleTime(v8::Isolate*, const String16& title) override;
+ void consoleTimeEnd(v8::Isolate*, const String16& title) override;
+ void consoleTimeStamp(v8::Isolate*, const String16& title) override;
protected:
+ virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;
+
v8::Isolate* m_isolate;
OwnPtr<V8Debugger> m_debugger;
};

Powered by Google App Engine
This is Rietveld 408576698