Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: third_party/WebKit/Source/core/frame/ConsoleBase.idl

Issue 1859293002: [DevTools] Move Console to v8_inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/ConsoleBase.idl
diff --git a/third_party/WebKit/Source/core/frame/ConsoleBase.idl b/third_party/WebKit/Source/core/frame/ConsoleBase.idl
index f3cc08e9109ce3c96349d5e34c5915ed7a93c390..b7d5e63dcab163bd542a5ff5b17760383f156627 100644
--- a/third_party/WebKit/Source/core/frame/ConsoleBase.idl
+++ b/third_party/WebKit/Source/core/frame/ConsoleBase.idl
@@ -34,31 +34,31 @@
NoInterfaceObject,
GarbageCollected,
] interface ConsoleBase {
- [CallWith=(ScriptArguments,ScriptState)] void debug();
- [CallWith=(ScriptArguments,ScriptState)] void error();
- [CallWith=(ScriptArguments,ScriptState)] void info();
- [CallWith=(ScriptArguments,ScriptState)] void log();
- [CallWith=(ScriptArguments,ScriptState)] void warn();
- [CallWith=(ScriptArguments,ScriptState)] void dir();
- [CallWith=(ScriptArguments,ScriptState)] void dirxml();
- [CallWith=(ScriptArguments,ScriptState)] void table();
- [CallWith=(ScriptArguments,ScriptState)] void trace();
- [CallWith=(ScriptArguments,ScriptState), ImplementedAs=assertCondition] void assert([Default=Undefined] optional boolean condition);
- [CallWith=(ScriptArguments,ScriptState)] void count();
- [DeprecateAs=ConsoleMarkTimeline] void markTimeline(optional DOMString title = null);
+ [Custom, Replaceable] readonly attribute object debug;
dgozman 2016/04/06 15:51:33 Should not be readonly.
kozy 2016/04/06 17:45:20 It's replaceable - users can replace this property
+ [Custom, Replaceable] readonly attribute object error;
+ [Custom, Replaceable] readonly attribute object info;
+ [Custom, Replaceable] readonly attribute object log;
dgozman 2016/04/06 15:51:33 Why object?
kozy 2016/04/06 17:45:20 There is no function type in WebIDL spec so functi
+ [Custom, Replaceable] readonly attribute object warn;
+ [Custom, Replaceable] readonly attribute object dir;
+ [Custom, Replaceable] readonly attribute object dirxml;
+ [Custom, Replaceable] readonly attribute object table;
+ [Custom, Replaceable] readonly attribute object trace;
+ [Custom, Replaceable] readonly attribute object assert;
+ [Custom, Replaceable] readonly attribute object count;
+ [Custom, Replaceable] readonly attribute object markTimeline;
- void profile(optional DOMString title = null);
- void profileEnd(optional DOMString title = null);
+ [Custom, Replaceable] readonly attribute object profile;
+ [Custom, Replaceable] readonly attribute object profileEnd;
- void time(optional DOMString title = null);
- [CallWith=ScriptState] void timeEnd(optional DOMString title = null);
- void timeStamp(optional DOMString title = null);
+ [Custom, Replaceable] readonly attribute object time;
+ [Custom, Replaceable] readonly attribute object timeEnd;
+ [Custom, Replaceable] readonly attribute object timeStamp;
- [DeprecateAs=ConsoleTimeline,CallWith=ScriptState] void timeline(optional DOMString title = null);
- [DeprecateAs=ConsoleTimelineEnd,CallWith=ScriptState] void timelineEnd(optional DOMString title = null);
+ [Custom, Replaceable] readonly attribute object timeline;
+ [Custom, Replaceable] readonly attribute object timelineEnd;
- [CallWith=(ScriptArguments,ScriptState)] void group();
- [CallWith=(ScriptArguments,ScriptState)] void groupCollapsed();
- void groupEnd();
- [CallWith=(ScriptArguments,ScriptState)] void clear();
+ [Custom, Replaceable] readonly attribute object group;
+ [Custom, Replaceable] readonly attribute object groupCollapsed;
+ [Custom, Replaceable] readonly attribute object groupEnd;
+ [Custom, Replaceable] readonly attribute object clear;
};

Powered by Google App Engine
This is Rietveld 408576698