android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java - Issue 1859163002: android webview: setShouldReuseGlobalForUnownedMainFrame

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 1859163002: android webview: setShouldReuseGlobalForUnownedMainFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java ('K') | « android_webview/java/src/org/chromium/android_webview/AwSettings.java ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

index 00352faf1338043dc2fc083079e0b7fb0540f822..d4322266be2d7f4c81a8ef0d646762d018e2e146 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

@@ -381,7 +381,8 @@ public class AwTestBase

return new AwTestContainerView(activity, allowHardwareAcceleration);

}

public AwSettings createAwSettings(Context context, boolean supportsLegacyQuirks) {

- return new AwSettings(context, false, supportsLegacyQuirks);

+ return new AwSettings(context, false /* isAccessFromFileURLsGrantedByDefault */,

+ supportsLegacyQuirks, false /* allowEmptyDocumentPersistence */);

sgurun-gerrit only 2016/04/05 18:24:15 does any aw test expect this to be true? we will s

boliu 2016/04/05 21:42:05 Obivously not, since tests are green without this

}