android webview: setShouldReuseGlobalForUnownedMainFrame

android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.android_webview.test;
 
 import android.app.Instrumentation;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.os.Build;
@@ skipping 363 matching lines @@
      *
      * Test cases can provide subclass instances to the createAwTest* methods in order to create an
      * AwContents instance with injected test dependencies.
      */
     public static class TestDependencyFactory extends AwContents.DependencyFactory {
         public AwTestContainerView createAwTestContainerView(AwTestRunnerActivity activity,
                 boolean allowHardwareAcceleration) {
             return new AwTestContainerView(activity, allowHardwareAcceleration);
         }
         public AwSettings createAwSettings(Context context, boolean supportsLegacyQuirks) {
-            return new AwSettings(context, false, supportsLegacyQuirks);
+            return new AwSettings(context, false /* isAccessFromFileURLsGrantedByDefault */,
+                    supportsLegacyQuirks, false /* allowEmptyDocumentPersistence */);

[sgurun-gerrit only, 2016/04/05 18:24:15]

does any aw test expect this to be true? we will see I think.

[boliu, 2016/04/05 21:42:05]

Obivously not, since tests are green without this CL

         }
     }
 
     protected TestDependencyFactory createTestDependencyFactory() {
         return new TestDependencyFactory();
     }
 
     public AwTestContainerView createAwTestContainerView(
             final AwContentsClient awContentsClient) {
         return createAwTestContainerView(awContentsClient, false);
@@ skipping 257 matching lines @@
             }
         });
 
         OnPageFinishedHelper onPageFinishedHelper = popupContentsClient.getOnPageFinishedHelper();
         int callCount = onPageFinishedHelper.getCallCount();
         onPageFinishedHelper.waitForCallback(callCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);
 
         return new PopupInfo(popupContentsClient, popupContainerView, popupContents);
     }
 }