Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1859123003: Add Mojo{Set,Get}DataPipeConsumerOptions() to the NaCl system thunks. (Closed)

Created:
4 years, 8 months ago by viettrungluu
Modified:
4 years, 8 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Mojo{Set,Get}DataPipeConsumerOptions() to the NaCl system thunks. Also actually add them properly to the native system thunks. R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/58ec2b7917fbe3241e9352fc338990aae878c72c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -21 lines) Patch
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 10 chunks +38 lines, -8 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 6 chunks +77 lines, -7 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/core_unittest.cc View 4 chunks +0 lines, -6 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 2 chunks +11 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.c View 1 chunk +19 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
(The NaCl stuff is just cargo-culted. Note that a bunch of files are generated from ...
4 years, 8 months ago (2016-04-05 20:22:36 UTC) #1
vardhan
lgtm
4 years, 8 months ago (2016-04-05 20:37:30 UTC) #2
viettrungluu
4 years, 8 months ago (2016-04-05 20:43:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58ec2b7917fbe3241e9352fc338990aae878c72c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698