Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1429)

Unified Diff: mojo/public/c/system/tests/core_unittest.cc

Issue 1859123003: Add Mojo{Set,Get}DataPipeConsumerOptions() to the NaCl system thunks. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/nacl/sfi/nacl_bindings_generator/interface.py ('k') | mojo/public/platform/nacl/libmojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/c/system/tests/core_unittest.cc
diff --git a/mojo/public/c/system/tests/core_unittest.cc b/mojo/public/c/system/tests/core_unittest.cc
index b64f14b5cbcc170550093023788a284c2120aa1b..f7186337eba4362d55abea03a6547342c537e779 100644
--- a/mojo/public/c/system/tests/core_unittest.cc
+++ b/mojo/public/c/system/tests/core_unittest.cc
@@ -74,8 +74,6 @@ TEST(CoreTest, InvalidHandle) {
EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
MojoEndWriteData(MOJO_HANDLE_INVALID, 1u));
buffer_size = static_cast<uint32_t>(sizeof(buffer));
-// TODO(vtl): Enable once I've added support for NaCl.
-#ifndef __native_client__
MojoDataPipeConsumerOptions dpc_options = {
sizeof(MojoDataPipeConsumerOptions), 0u};
EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
@@ -84,7 +82,6 @@ TEST(CoreTest, InvalidHandle) {
MojoGetDataPipeConsumerOptions(
MOJO_HANDLE_INVALID, &dpc_options,
static_cast<uint32_t>(sizeof(dpc_options))));
-#endif
EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
MojoReadData(MOJO_HANDLE_INVALID, buffer, &buffer_size,
MOJO_READ_DATA_FLAG_NONE));
@@ -318,8 +315,6 @@ TEST(CoreTest, MAYBE_BasicDataPipe) {
// the producer never-writable?
}
-// TODO(vtl): Enable once I've added support for NaCl.
-#ifndef __native_client__
TEST(CoreTest, DataPipeReadThreshold) {
MojoHandle hp = MOJO_HANDLE_INVALID;
MojoHandle hc = MOJO_HANDLE_INVALID;
@@ -419,7 +414,6 @@ TEST(CoreTest, DataPipeReadThreshold) {
EXPECT_EQ(MOJO_RESULT_OK, MojoClose(hp));
EXPECT_EQ(MOJO_RESULT_OK, MojoClose(hc));
}
-#endif
// TODO(ncbray): enable this test once NaCl supports the corresponding APIs.
#ifdef __native_client__
« no previous file with comments | « mojo/nacl/sfi/nacl_bindings_generator/interface.py ('k') | mojo/public/platform/nacl/libmojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698