[debugger] ScopeIterator should unwrap debug-evaluate contexts.

[debugger] ScopeIterator should unwrap debug-evaluate contexts.

If we use ScopeIterator inside a debug-evaluate call, we may iterate
over a debug-evaluate context that we created for the debug-evaluate
call. This may trigger assertions.

The solution is to have the ScopeIterator hide debug-evaluate contexts
by unwrapping it if it comes across any.

R=cbruni@chromium.org
BUG=chromium:599662
LOG=N

Committed: https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86
Cr-Commit-Position: refs/heads/master@{#35258}

[Camillo Bruni, 2016-04-05 11:37:59]

lgtm

https://codereview.chromium.org/1859033002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1859033002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:128: if (!context_->IsDebugEvaluateContext()) return;
so you can have only one debug context (or directly consecutive ones)?
As a smalltalker I am used to have my debug session trigger other debuggers :D

[Yang, 2016-04-05 11:43:00]

https://codereview.chromium.org/1859033002/diff/1/src/debug/debug-scopes.cc
File src/debug/debug-scopes.cc (right):

https://codereview.chromium.org/1859033002/diff/1/src/debug/debug-scopes.cc#n...
src/debug/debug-scopes.cc:128: if (!context_->IsDebugEvaluateContext()) return;
On 2016/04/05 11:37:59, Camillo Bruni wrote:
> so you can have only one debug context (or directly consecutive ones)?
> As a smalltalker I am used to have my debug session trigger other debuggers :D

No. The point of this CL is that the scope iterator should see the scope and
context chain in its original state. Only that way you actually can debug inside
a debug-evaluate. The test case shows how. Prior to this CL the nested debug
session would see debug-evaluate contexts but not the contexts it wraps.

[Yang, 2016-04-05 11:43:05]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-04-05 11:43:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1859033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1859033002/1

[commit-bot: I haz the power, 2016-04-05 12:07:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-05 12:08:26]

Description was changed from

==========
[debugger] ScopeIterator should unwrap debug-evaluate contexts.

If we use ScopeIterator inside a debug-evaluate call, we may iterate
over a debug-evaluate context that we created for the debug-evaluate
call. This may trigger assertions.

The solution is to have the ScopeIterator hide debug-evaluate contexts
by unwrapping it if it comes across any.

R=cbruni@chromium.org
BUG=chromium:599662
LOG=N
==========

to

==========
[debugger] ScopeIterator should unwrap debug-evaluate contexts.

If we use ScopeIterator inside a debug-evaluate call, we may iterate
over a debug-evaluate context that we created for the debug-evaluate
call. This may trigger assertions.

The solution is to have the ScopeIterator hide debug-evaluate contexts
by unwrapping it if it comes across any.

R=cbruni@chromium.org
BUG=chromium:599662
LOG=N

Committed: https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86
Cr-Commit-Position: refs/heads/master@{#35258}
==========

[commit-bot: I haz the power, 2016-04-05 12:08:27]

Patchset 1 (id:??) landed as
https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86
Cr-Commit-Position: refs/heads/master@{#35258}