Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 18587003: Rename PrerenderWebMediaPlayer to PrerenderMediaLoadDeferrer. (Closed)

Created:
7 years, 5 months ago by scherkus (not reviewing)
Modified:
7 years, 5 months ago
Reviewers:
Nico, gavinp
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Rename PrerenderWebMediaPlayer to PrerenderMediaLoadDeferrer. As of r209797 it no longer inherits from WebKit::WebMediaPlayer. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210495

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -106 lines) Patch
M chrome/chrome_renderer.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/renderer/prerender/prerender_media_load_deferrer.h View 3 chunks +8 lines, -10 lines 0 comments Download
A + chrome/renderer/prerender/prerender_media_load_deferrer.cc View 3 chunks +8 lines, -7 lines 0 comments Download
D chrome/renderer/prerender/prerender_webmediaplayer.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/renderer/prerender/prerender_webmediaplayer.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
gavinp: care to take a look?
7 years, 5 months ago (2013-07-03 01:00:04 UTC) #1
gavinp
lgtm
7 years, 5 months ago (2013-07-08 13:40:15 UTC) #2
scherkus (not reviewing)
thakis: OWNERS for renames in chrome/renderer/chrome_content_renderer_client.cc
7 years, 5 months ago (2013-07-08 19:43:48 UTC) #3
Nico
lgtm
7 years, 5 months ago (2013-07-08 20:12:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/18587003/12001
7 years, 5 months ago (2013-07-08 20:24:02 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 02:18:06 UTC) #6
Message was sent while issue was closed.
Change committed as 210495

Powered by Google App Engine
This is Rietveld 408576698