Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1858663002: Destroy PrerenderMessageFilter on the UI thread. (Closed)

Created:
4 years, 8 months ago by Bernhard Bauer
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, chrisha, gavinp
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy PrerenderMessageFilter on the UI thread. PrerenderMessageFilter contains a subscription to a KeyedServiceShutdownNotifier, which needs to be destroyed on the UI thread. BUG=600368 Committed: https://crrev.com/a2b155292067c0b71c49c6d355c6b13374629890 Cr-Commit-Position: refs/heads/master@{#385458}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/prerender/prerender_message_filter.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/prerender/prerender_message_filter.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 8 months ago (2016-04-04 17:16:21 UTC) #2
Lei Zhang
Looks ok, but deferring to gavinp.
4 years, 8 months ago (2016-04-04 21:01:38 UTC) #4
gavinp
lgtm.
4 years, 8 months ago (2016-04-06 13:12:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858663002/1
4 years, 8 months ago (2016-04-06 13:40:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 14:30:01 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 14:31:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2b155292067c0b71c49c6d355c6b13374629890
Cr-Commit-Position: refs/heads/master@{#385458}

Powered by Google App Engine
This is Rietveld 408576698