Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: chrome/browser/prerender/prerender_message_filter.cc

Issue 1858663002: Destroy PrerenderMessageFilter on the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_message_filter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_message_filter.cc
diff --git a/chrome/browser/prerender/prerender_message_filter.cc b/chrome/browser/prerender/prerender_message_filter.cc
index d8d04de5f6f41956fedbef79c672b458d776b598..f69a1be4cedc806c4c5743f0ab9d1cd520b5350b 100644
--- a/chrome/browser/prerender/prerender_message_filter.cc
+++ b/chrome/browser/prerender/prerender_message_filter.cc
@@ -55,6 +55,7 @@ PrerenderMessageFilter::PrerenderMessageFilter(int render_process_id,
}
PrerenderMessageFilter::~PrerenderMessageFilter() {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
}
// static
@@ -91,6 +92,11 @@ void PrerenderMessageFilter::OnChannelClosing() {
base::Bind(&PrerenderMessageFilter::OnChannelClosingInUIThread, this));
}
+void PrerenderMessageFilter::OnDestruct() const {
+ // |shutdown_notifier_| needs to be destroyed on the UI thread.
+ BrowserThread::DeleteOnUIThread::Destruct(this);
+}
+
void PrerenderMessageFilter::OnAddPrerender(
int prerender_id,
const PrerenderAttributes& attributes,
« no previous file with comments | « chrome/browser/prerender/prerender_message_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698