Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1858593002: [interpreter] Update bytecode expectations for ES6 instanceof. (Closed)

Created:
4 years, 8 months ago by oth
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@oth-0047-peep-return
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Update bytecode expectations for ES6 instanceof. Fixes updating golden files following instanceof change. BUG=v8:4280 LOG=N R=rmcilroy@chromium.org,ssanfilippo@chromium.org Committed: https://crrev.com/fa2fbcfc2d7ff8c937af15c6efbd2e143201e968 Cr-Commit-Position: refs/heads/master@{#35406}

Patch Set 1 #

Patch Set 2 : Decouple from elided stores. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -28 lines) Patch
M test/cctest/interpreter/bytecode_expectations/IfConditions.golden View 4 chunks +78 lines, -22 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858593002/1
4 years, 8 months ago (2016-04-04 09:44:23 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/17874)
4 years, 8 months ago (2016-04-04 09:59:53 UTC) #4
oth
PTAL. generate-bytecode-expectations crashes today without this.
4 years, 8 months ago (2016-04-11 10:23:11 UTC) #5
rmcilroy
LGTM, thanks.
4 years, 8 months ago (2016-04-11 12:29:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858593002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858593002/40001
4 years, 8 months ago (2016-04-12 08:21:04 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-12 08:42:27 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 08:42:42 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fa2fbcfc2d7ff8c937af15c6efbd2e143201e968
Cr-Commit-Position: refs/heads/master@{#35406}

Powered by Google App Engine
This is Rietveld 408576698