Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: test/cctest/interpreter/bytecode_expectations/IfConditions.golden

Issue 1858593002: [interpreter] Update bytecode expectations for ES6 instanceof. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@oth-0047-peep-return
Patch Set: Rebase. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/IfConditions.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/IfConditions.golden b/test/cctest/interpreter/bytecode_expectations/IfConditions.golden
index f450f3f32116d73717d1eab90b314d615962915e..f7217462a8ecdd9c3a36944dabe24a9ab270ea4c 100644
--- a/test/cctest/interpreter/bytecode_expectations/IfConditions.golden
+++ b/test/cctest/interpreter/bytecode_expectations/IfConditions.golden
@@ -3,7 +3,7 @@
#
---
-pool type: number
+pool type: mixed
execute: yes
wrap: no
test function name: f
@@ -415,8 +415,8 @@ bytecodes: [
B(Return),
]
constant pool: [
- 0.01,
- 265,
+ InstanceType::HEAP_NUMBER_TYPE,
+ kInstanceTypeDontCare,
]
handlers: [
]
@@ -642,7 +642,7 @@ bytecodes: [
B(Return),
]
constant pool: [
- 265,
+ kInstanceTypeDontCare,
]
handlers: [
]
@@ -662,71 +662,127 @@ snippet: "
}
f(1, 1);
"
-frame size: 1
+frame size: 6
parameter count: 3
-bytecode array length: 107
+bytecode array length: 226
bytecodes: [
B(StackCheck),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestEqual), R(0),
+ B(TestEqual), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestEqualStrict), R(0),
+ B(TestEqualStrict), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestLessThan), R(0),
+ B(TestLessThan), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestGreaterThan), R(0),
+ B(TestGreaterThan), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestLessThanOrEqual), R(0),
+ B(TestLessThanOrEqual), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestGreaterThanOrEqual), R(0),
+ B(TestGreaterThanOrEqual), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
- B(Star), R(0),
+ B(Star), R(3),
B(Ldar), R(arg1),
- B(TestIn), R(0),
+ B(TestIn), R(3),
B(JumpIfFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(Ldar), R(arg0),
B(Star), R(0),
B(Ldar), R(arg1),
- B(TestInstanceOf), R(0),
- B(JumpIfFalse), U8(5),
+ B(Star), R(1),
+ B(Star), R(3),
+ B(InvokeIntrinsic), U16(Runtime::k_IsJSReceiver), R(3), U8(1),
+ B(JumpIfToBooleanFalse), U8(4),
+ B(Jump), U8(16),
+ B(LdaSmi), U8(60),
+ B(Star), R(3),
+ B(LdaConstant), U8(0),
+ B(Star), R(4),
+ B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
+ B(Throw),
+ B(Ldar), R(1),
+ B(Star), R(3),
+ B(LdaConstant), U8(1),
+ B(KeyedLoadIC), R(3), U8(1),
+ B(Star), R(2),
+ B(Star), R(3),
+ B(LdaUndefined),
+ B(TestEqualStrict), R(3),
+ B(JumpIfFalse), U8(55),
+ B(Ldar), R(1),
+ B(TypeOf),
+ B(Star), R(3),
+ B(LdaConstant), U8(2),
+ B(TestEqualStrict), R(3),
+ B(JumpIfFalse), U8(4),
+ B(Jump), U8(16),
+ B(LdaSmi), U8(16),
+ B(Star), R(3),
+ B(LdaConstant), U8(0),
+ B(Star), R(4),
+ B(CallRuntime), U16(Runtime::kNewTypeError), R(3), U8(2),
+ B(Throw),
+ B(CallRuntime), U16(Runtime::k_GetOrdinaryHasInstance), R(0), U8(0),
+ B(Star), R(2),
+ B(Star), R(3),
+ B(Ldar), R(1),
+ B(Star), R(4),
+ B(Ldar), R(0),
+ B(Star), R(5),
+ B(CallRuntime), U16(Runtime::k_Call), R(3), U8(3),
+ B(Star), R(2),
+ B(Jump), U8(23),
+ B(Ldar), R(2),
+ B(Star), R(3),
+ B(Ldar), R(1),
+ B(Star), R(4),
+ B(Ldar), R(0),
+ B(Star), R(5),
+ B(CallRuntime), U16(Runtime::k_Call), R(3), U8(3),
+ B(LogicalNot),
+ B(LogicalNot),
+ B(Star), R(2),
+ B(Ldar), R(2),
+ B(JumpIfToBooleanFalse), U8(5),
B(LdaSmi), U8(1),
B(Return),
B(LdaZero),
B(Return),
]
constant pool: [
+ InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
+ InstanceType::SYMBOL_TYPE,
+ InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
]
handlers: [
]
« no previous file with comments | « no previous file | test/cctest/interpreter/test-bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698