Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1858403003: headless: Require the user to pass in an initial URL (Closed)

Created:
4 years, 8 months ago by Sami
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Require the user to pass in an initial URL Require the user to pass in an initial URL when creating a HeadlessWebContents. This is to ensure that we have a navigation that initializes the renderer, making it possible to inspect the tab. BUG=595353, 546953 Committed: https://crrev.com/ab258d6d6ddc01e681716ec2be8433bc77b682a3 Cr-Commit-Position: refs/heads/master@{#385476}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -53 lines) Patch
M headless/app/headless_shell.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 1 chunk +10 lines, -2 lines 2 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 1 chunk +4 lines, -7 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 1 chunk +29 lines, -9 lines 0 comments Download
M headless/public/headless_browser.h View 1 chunk +3 lines, -1 line 0 comments Download
M headless/public/headless_web_contents.h View 2 chunks +7 lines, -6 lines 0 comments Download
M headless/test/headless_browser_test.h View 2 chunks +18 lines, -3 lines 0 comments Download
M headless/test/headless_browser_test.cc View 5 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sami
4 years, 8 months ago (2016-04-06 15:14:16 UTC) #3
alex clarke (OOO till 29th)
https://codereview.chromium.org/1858403003/diff/1/headless/lib/browser/headless_browser_impl.cc File headless/lib/browser/headless_browser_impl.cc (right): https://codereview.chromium.org/1858403003/diff/1/headless/lib/browser/headless_browser_impl.cc#newcode43 headless/lib/browser/headless_browser_impl.cc:43: if (!web_contents->OpenURL(initial_url)) Suppose this failed for some reason, how ...
4 years, 8 months ago (2016-04-06 15:34:53 UTC) #4
Sami
https://codereview.chromium.org/1858403003/diff/1/headless/lib/browser/headless_browser_impl.cc File headless/lib/browser/headless_browser_impl.cc (right): https://codereview.chromium.org/1858403003/diff/1/headless/lib/browser/headless_browser_impl.cc#newcode43 headless/lib/browser/headless_browser_impl.cc:43: if (!web_contents->OpenURL(initial_url)) On 2016/04/06 15:34:53, alexclarke1 wrote: > Suppose ...
4 years, 8 months ago (2016-04-06 15:40:16 UTC) #5
alex clarke (OOO till 29th)
lgtm
4 years, 8 months ago (2016-04-06 15:44:51 UTC) #6
altimin
lgtm
4 years, 8 months ago (2016-04-06 15:46:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858403003/1
4 years, 8 months ago (2016-04-06 15:53:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 16:33:14 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 16:34:27 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab258d6d6ddc01e681716ec2be8433bc77b682a3
Cr-Commit-Position: refs/heads/master@{#385476}

Powered by Google App Engine
This is Rietveld 408576698