headless/lib/browser/headless_web_contents_impl.cc - Issue 1858403003: headless: Require the user to pass in an initial URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_web_contents_impl.cc

Issue 1858403003: headless: Require the user to pass in an initial URL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« headless/lib/browser/headless_browser_impl.cc ('K') | « headless/lib/browser/headless_web_contents_impl.h ('k') | headless/lib/headless_browser_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: headless/lib/browser/headless_web_contents_impl.cc

diff --git a/headless/lib/browser/headless_web_contents_impl.cc b/headless/lib/browser/headless_web_contents_impl.cc

index 04c00e54c63b539003f708d16da978e9ab01b65b..f58dfe0671c2b627794fc9b2540eb9624d134809 100644

--- a/headless/lib/browser/headless_web_contents_impl.cc

+++ b/headless/lib/browser/headless_web_contents_impl.cc

@@ -31,6 +31,8 @@ class WebContentsObserverAdapter : public content::WebContentsObserver {

~WebContentsObserverAdapter() override {}

+ void RenderViewReady() override { observer_->WebContentsReady(); }

void DocumentOnLoadCompletedInMainFrame() override {

observer_->DocumentOnLoadCompletedInMainFrame();

}