Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1858233004: cc : Layers with background filters are drawn only if parent is drawn. (Closed)

Created:
4 years, 8 months ago by jaydasika
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Layers with background filters are drawn only if parent is drawn. Also changes call from parent to IsRootLayer in draw_property_utils. BUG=594024 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/369c24b2b6b5cd98b2839bf79675b4aae8eda0f5 Cr-Commit-Position: refs/heads/master@{#385578}

Patch Set 1 #

Patch Set 2 : Use IsRootLayer #

Patch Set 3 : #

Patch Set 4 : Fix unit test crash on bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M cc/trees/draw_property_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 3 1 chunk +31 lines, -10 lines 0 comments Download
M cc/trees/property_tree.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
jaydasika
This is to ensure that when is_drawn is false for parent, it remains so for ...
4 years, 8 months ago (2016-04-06 17:17:06 UTC) #5
Ian Vollick
On 2016/04/06 17:17:06, jaydasika wrote: > This is to ensure that when is_drawn is false ...
4 years, 8 months ago (2016-04-06 17:54:00 UTC) #6
jaydasika
On 2016/04/06 17:54:00, vollick wrote: > On 2016/04/06 17:17:06, jaydasika wrote: > > This is ...
4 years, 8 months ago (2016-04-06 19:54:49 UTC) #7
Ian Vollick
On 2016/04/06 19:54:49, jaydasika wrote: > On 2016/04/06 17:54:00, vollick wrote: > > On 2016/04/06 ...
4 years, 8 months ago (2016-04-06 20:00:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858233004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858233004/40001
4 years, 8 months ago (2016-04-06 20:02:25 UTC) #10
jaydasika
One more change to fix DCHECK hit by the modified unit test on some bots.
4 years, 8 months ago (2016-04-06 20:50:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858233004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858233004/60001
4 years, 8 months ago (2016-04-06 22:21:39 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-06 23:44:28 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 23:46:04 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/369c24b2b6b5cd98b2839bf79675b4aae8eda0f5
Cr-Commit-Position: refs/heads/master@{#385578}

Powered by Google App Engine
This is Rietveld 408576698