Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3527)

Unified Diff: cc/trees/property_tree.cc

Issue 1858233004: cc : Layers with background filters are drawn only if parent is drawn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix unit test crash on bots Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/layer_tree_host_common_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/property_tree.cc
diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc
index bc019dcd8a5dc4ef7990fd65159cf96017629669..e3025b231b575b3e5f98bb89df8ecbf61a095bd3 100644
--- a/cc/trees/property_tree.cc
+++ b/cc/trees/property_tree.cc
@@ -1210,9 +1210,10 @@ void EffectTree::UpdateIsDrawn(EffectNode* node, EffectNode* parent_node) {
// 2) Nodes that have a background filter.
// 3) Nodes with animating screen space opacity are drawn if their parent is
// drawn irrespective of their opacity.
- if (node->data.has_copy_request || node->data.has_background_filters)
+ if (node->data.has_copy_request)
node->data.is_drawn = true;
- else if (node->data.opacity == 0.f && !node->data.has_animated_opacity)
+ else if (node->data.opacity == 0.f && !node->data.has_animated_opacity &&
+ !node->data.has_background_filters)
node->data.is_drawn = false;
else if (parent_node)
node->data.is_drawn = parent_node->data.is_drawn;
« no previous file with comments | « cc/trees/layer_tree_host_common_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698