third_party/WebKit/Source/core/svg/SVGImageElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGImageElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGImageElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGImageElement.cpp b/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

index 15976d9d2d344a4873f215ec76846012cce146d5..8bd5312c2f0d97d1f5dd7047d15bfaf68aa7103c 100644

--- a/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGImageElement.cpp

@@ -134,7 +134,7 @@ void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName)

if (SVGURIReference::isKnownAttribute(attrName)) {

SVGElement::InvalidationGuard invalidationGuard(this);

- if (inDocument())

+ if (inShadowIncludingDocument())

imageLoader().updateFromElement(ImageLoader::UpdateIgnorePreviousError);

else

m_needsLoaderURIUpdate = true;

@@ -177,7 +177,7 @@ void SVGImageElement::attach(const AttachContext& context)

Node::InsertionNotificationRequest SVGImageElement::insertedInto(ContainerNode* rootParent)

{

SVGGraphicsElement::insertedInto(rootParent);

- if (!rootParent->inDocument())

+ if (!rootParent->inShadowIncludingDocument())

return InsertionDone;

// We can only resolve base URIs properly after tree insertion - hence, URI mutations while