third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

index e5811466366d5e1fc8155f06a7d8d087c4342f1e..c1d7bd82ef879be38fa98a1c295b3d77aaf4c2fa 100644

--- a/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGFEImageElement.cpp

@@ -91,7 +91,7 @@ void SVGFEImageElement::fetchImageResource()

void SVGFEImageElement::buildPendingResource()

{

clearResourceReferences();

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

AtomicString id;

@@ -139,13 +139,13 @@ Node::InsertionNotificationRequest SVGFEImageElement::insertedInto(ContainerNode

void SVGFEImageElement::removedFrom(ContainerNode* rootParent)

{

SVGFilterPrimitiveStandardAttributes::removedFrom(rootParent);

- if (rootParent->inDocument())

+ if (rootParent->inShadowIncludingDocument())

clearResourceReferences();

}

void SVGFEImageElement::notifyFinished(Resource*)

{

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

Element* parent = parentElement();