third_party/WebKit/Source/core/html/HTMLObjectElement.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

index e57dd593ec765a69904b08ec6f238d4b10ee2a15..572d4502d462bf4a9e5e35ff5930940f731e07f3 100644

--- a/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

@@ -319,7 +319,7 @@ void HTMLObjectElement::removedFrom(ContainerNode* insertionPoint)

void HTMLObjectElement::childrenChanged(const ChildrenChange& change)

{

- if (inDocument() && !useFallbackContent()) {

+ if (inShadowIncludingDocument() && !useFallbackContent()) {

setNeedsWidgetUpdate(true);

lazyReattachIfNeeded();

}

@@ -364,7 +364,7 @@ void HTMLObjectElement::renderFallbackContent()

if (useFallbackContent())

return;

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

// Before we give up and use fallback content, check to see if this is a MIME type issue.