third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp - Issue 1858163002: Rename inDocument() to inShadowIncludingDocument()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

Issue 1858163002: Rename inDocument() to inShadowIncludingDocument() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp b/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

index 41335e85b2ee74627f77c4555a11ab81932bba58..d31bbb831f8422b94b96ad239e2f30ed92ce06ab 100644

--- a/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMetaElement-in.cpp

@@ -455,7 +455,7 @@ void HTMLMetaElement::didNotifySubtreeInsertionsToDocument()

static bool inDocumentHead(HTMLMetaElement* element)

{

- if (!element->inDocument())

+ if (!element->inShadowIncludingDocument())

return false;

return Traversal<HTMLHeadElement>::firstAncestor(*element);

@@ -463,7 +463,7 @@ static bool inDocumentHead(HTMLMetaElement* element)

void HTMLMetaElement::process()

{

- if (!inDocument())

+ if (!inShadowIncludingDocument())

return;

// All below situations require a content attribute (which can be the empty string).