[Geolocation] Attach user gesture indicator to permission request call.

content/browser/geolocation/geolocation_dispatcher_host.cc

Index: content/browser/geolocation/geolocation_dispatcher_host.cc
diff --git a/content/browser/geolocation/geolocation_dispatcher_host.cc b/content/browser/geolocation/geolocation_dispatcher_host.cc
index edb2692f36f232894ace3e678a8a17d9ec4c43d8..0bcb41b71a3633fe3425205b236aaa167eb9c221 100644
--- a/content/browser/geolocation/geolocation_dispatcher_host.cc
+++ b/content/browser/geolocation/geolocation_dispatcher_host.cc
@@ -60,7 +60,8 @@ class GeolocationDispatcherHostImpl : public GeolocationDispatcherHost {
 
   void OnRequestPermission(int render_view_id,
                            int bridge_id,
-                           const GURL& requesting_frame);
+                           const GURL& requesting_frame,
+                           bool user_gesture);
   void OnCancelPermissionRequest(int render_view_id,
                                  int bridge_id,
                                  const GURL& requesting_frame);
@@ -159,7 +160,8 @@ void GeolocationDispatcherHostImpl::OnLocationUpdate(
 void GeolocationDispatcherHostImpl::OnRequestPermission(
     int render_view_id,
     int bridge_id,
-    const GURL& requesting_frame) {
+    const GURL& requesting_frame,
+    bool user_gesture) {

[jamesr, 2014/03/06 21:37:43]

please add a TODO() or something here indicating that you intend to use this
flag for something.  As it is, this patch adds a flag that goes nowhere and thus
the entire patch appears to be dead code.  If you plan to extend this later
that's fine but you need to leave an indication of that or another developer
could look at the code, rightly determine that it's dead, and delete it.

[Greg Billock, 2014/03/08 17:15:33]

I pushed this out to the browser side and added the todo there.

   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DVLOG(1) << __FUNCTION__ << " " << render_process_id_ << ":"
            << render_view_id << ":" << bridge_id;