[Geolocation] Attach user gesture indicator to permission request call.

content/browser/geolocation/geolocation_dispatcher_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/geolocation/geolocation_dispatcher_host.h"
 
 #include <map>
 #include <set>
 #include <utility>
 
@@ skipping 42 matching lines @@
 
   // GeolocationDispatcherHost
   virtual bool OnMessageReceived(const IPC::Message& msg,
                                  bool* msg_was_ok) OVERRIDE;
 
  private:
   virtual ~GeolocationDispatcherHostImpl();
 
   void OnRequestPermission(int render_view_id,
                            int bridge_id,
-                           const GURL& requesting_frame);
+                           const GURL& requesting_frame,
+                           bool user_gesture);
   void OnCancelPermissionRequest(int render_view_id,
                                  int bridge_id,
                                  const GURL& requesting_frame);
   void OnStartUpdating(int render_view_id,
                        const GURL& requesting_frame,
                        bool enable_high_accuracy);
   void OnStopUpdating(int render_view_id);
 
 
   virtual void PauseOrResume(int render_view_id, bool should_pause) OVERRIDE;
@@ skipping 78 matching lines @@
        geolocation_renderers_.begin();
        it != geolocation_renderers_.end(); ++it) {
     if (!(it->second.is_paused))
       Send(new GeolocationMsg_PositionUpdated(it->first, geoposition));
   }
 }
 
 void GeolocationDispatcherHostImpl::OnRequestPermission(
     int render_view_id,
     int bridge_id,
-    const GURL& requesting_frame) {
+    const GURL& requesting_frame,
+    bool user_gesture) {

[jamesr, 2014/03/06 21:37:43]

please add a TODO() or something here indicating that you intend to use this
flag for something.  As it is, this patch adds a flag that goes nowhere and thus
the entire patch appears to be dead code.  If you plan to extend this later
that's fine but you need to leave an indication of that or another developer
could look at the code, rightly determine that it's dead, and delete it.

[Greg Billock, 2014/03/08 17:15:33]

I pushed this out to the browser side and added the todo there.

   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DVLOG(1) << __FUNCTION__ << " " << render_process_id_ << ":"
            << render_view_id << ":" << bridge_id;
   if (geolocation_permission_context_.get()) {
     geolocation_permission_context_->RequestGeolocationPermission(
         render_process_id_,
         render_view_id,
         bridge_id,
         requesting_frame,
         base::Bind(&SendGeolocationPermissionResponse,
@@ skipping 123 matching lines @@
 }
 
 GeolocationDispatcherHost::GeolocationDispatcherHost()
     : BrowserMessageFilter(GeolocationMsgStart) {
 }
 
 GeolocationDispatcherHost::~GeolocationDispatcherHost() {
 }
 
 }  // namespace content